feat: move tui code to tui package #591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes PluginTerminalUI available for sops (and other third parties) so they can more easily support plugins.
1 task
|
From the SOPS point of view, having this as a reusable package would be really great! Basically copy'n'pasting that code over (and keeping it up-to-date) would IMO be a last-resort solution, which I'd like to avoid. |
|
CI needs a fix: |
This comment has been minimized.
This comment has been minimized.
$ staticcheck ./... | fmt -w 80 -s internal/format/format.go:204:17: error strings should not end with punctuation or newlines (ST1005) internal/stream/stream.go:15:2: "golang.org/x/crypto/poly1305" is deprecated: Poly1305 as implemented by this package is a cryptographic building block that is not safe for general purpose use. For encryption, use the full ChaCha20-Poly1305 construction implemented by golang.org/x/crypto/chacha20poly1305. For authentication, use a general purpose MAC such as HMAC implemented by crypto/hmac. (SA1019) plugin/client.go:385:2: field stderr is unused (U1000) $ gotip vet ./cmd/... cmd/age-keygen/keygen.go:161:13: non-constant format string in call to log.Printf
|
I missed that the static checks needed to be fixed. I just cherry-picked #589 into this branch. @FiloSottile, it would be great if we could get this merged 🙏 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes PluginTerminalUI available for sops (and other third parties) to support plugins more easily.